fix(admin_audit): handle audit reads for new files - #63305
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
refactor(admin_audit): improve audit parameter handling refactor(admin_audit): improve audit parameter handling - clarify missing-parameter validation and logging; - support DateTimeInterface values; - simplify the vsprintf invocation. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
And align event handlers for consistency. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
CarlSchwan,
come-nc and
leftybournes
and removed request for
a team
August 17, 2026 00:24
CarlSchwan
added
3. to review
CarlSchwan
approved these changes
Aug 17, 2026
come-nc
approved these changes
Aug 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
Handle audit logging for file reads that occur before a new file has been assigned a file ID.
BeforeNodeReadEventcan provide aNonExistingFilewithout an ID. Although #47071 avoided callinggetId()for this case,Action::log()still treated the resulting parameter as missing because it used!isset(). As a result, the intended audit entry was not written.Changes:
not-yet-assignedas the audit ID forNonExistingFilereads.nullvalues as valid audit parameters.Action::log()parameter validation and formatting.DateTimeandDateTimeImmutablethroughDateTimeInterface.Action::log()with PHPDoc to values that can be safely normalized and passed tovsprintf()without introducing a behavior change (static analysis only).This preserves the audit event and makes the unavailable ID explicit in the log output:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)